chore: separate benchmarks into a distinct CI job#3873
Open
maxrjones wants to merge 2 commits intozarr-developers:mainfrom
Open
chore: separate benchmarks into a distinct CI job#3873maxrjones wants to merge 2 commits intozarr-developers:mainfrom
maxrjones wants to merge 2 commits intozarr-developers:mainfrom
Conversation
github-actions
bot
added
the
needs release notes
maxrjones
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3873 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 86 86
Lines 10709 10709
=======================================
Hits 9950 9950
Misses 759 759 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the CI workflows such that the benchmarking test suite is not run on every environment in the matrix.
What changed
--ignore tests/benchmarkstorun-coverageandrun-coverage-htmlhatch scripts so the main test matrix no longer runs benchmark testsbenchmarksjob to the test workflow that runs benchmarks in parallel with the other test jobstest-completegates on the newbenchmarksjobMotivation
Benchmark tests (especially sharded morton indexing) take 15-22s each and dominate wall time when included in the main test suite. Running them as a separate parallel job avoids blocking the test matrix while still catching breakage on every PR. The assumption here is that these tests are not necessary to run on every OS and dependency set.
TODO:
docs/user-guide/*.mdchanges/